Support ANSI escape color codes in NINJA_STATUS #1454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for ANSI escape sequences used for colorization to the job status indicator, and updates `ElideMiddle()` to account for the non-obvious change in text width. As an example, the following will now emit the job status in green: env NINJA_STATUS="\\033[32m[%f/%t] \\033[0m" ninja; Invalid color escape codes are treated as plain text (as before). ANSI escape sequences apart from `\033...m` are not supported. Closes ninja-build#713. Closes ninja-build#912.
mqudsi
force-pushed
the
ninja_status_color
branch
from
75e818c to
5f42d00
Compare
mqudsi
added a commit
to mqudsi/ninja
that referenced
this pull request
Jul 31, 2018
Set the default `NINJA_STATUS` and the "FAILED" text on job failure to use ANSI color code escapes if running under a smart terminal. Requires ninja-build#1454 to be merged first.
|
If this is used over #912, the first commit of that PR is still relevant. |
|
btw: ANSI escape color codes in env $'NINJA_STATUS=\x1b[32m[%f/%t] \x1b[0m' ninjaIt's true that this will break |
|
Superseded by #1494. |
mqudsi
added a commit
to mqudsi/ninja
that referenced
this pull request
Jan 1, 2019
Set the default `NINJA_STATUS` and the "FAILED" text on job failure to use ANSI color code escapes if running under a smart terminal. Requires ninja-build#1454 to be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ANSI escape sequences used for colorization to the job
status indicator, and updates
ElideMiddle()to account for thenon-obvious change in text width.
As an example, the following will now emit the job status in green:
env NINJA_STATUS="\\033[32m[%f/%t] \\033[0m" ninja;Invalid color escape codes are treated as plain text (as before). ANSI
escape sequences apart from
\033...mare not supported.Closes #713. Closes #912.